Lab 4 hustle

 Hey PC readers:

 

Welcome back to my blog. So this week, we had to collaborate with one of our peers to work on their repo. We had to add the ignore-URL feature to their repositories. So I chose my peer Muskan Shinh to work on her repo. She also worked on the Node JS. I had the fork of her repo and cloned it on local directory. I created a branch with the same name as issue logged on her repo i.e. Issue-6.

I started by adding the ignoreurl.txt file and added the given URLs and comments by professor to add in that file like this:

 

Then, I started adding the functionality of it. The code will parse the URLs in the ignoreurl.txt file and check the URL array originally parsed. If the ignore URL pattern is added in the final URL array, it will ignore those URLs and process the rest of them. I pushed all the work on the branch. Since Muskan had hard-coded values for the command line arguments so I had to use the --ignore on the same index with others, to match her coding style. So the command went like this:

I then went on to commit the changes and push the work to my issue-6 branch. I was using git commit -am "message" but I don't know why it was not committing ignoreurl.txt in that one. I did it twice. Alas, I had to use git add filename, and then commit. Then only it worked. I updated the issue to let Muskan know about the work being done, and communicated the same on Slack also.

The working feature:  

The repo: https://github.com/chawlapalak/urltester/tree/issue-6

Review on my repo:

Ekaterina worked on my repo to add the same feature. She added the feature and let me know on slack that the feature was added with the link of her branch to add remote and fetch. I followed the steps given on the Lab 4 instructions and added the remote and fetched the branch she worked on. I added the branch on my local directory as issue-12 also. I checked her work. It was good. Although the readMe was not updated with the feature, so I told her on the issue to add it. She added the feature later on and commented on the issue. I pulled the changes and merged them to my master. I merged and closed the issue on my repo. 

https://github.com/chawlapalak/Url-Inspector/commit/fc3d954213df763609a624474f5c6b67619afe0e

 

 

That is all for today, see you in the next blog. Take care and good luck for the mid-terms!

Best,

PC